Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DynamicDML to remove incompatible method signatures #717

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Refactor DynamicDML to remove incompatible method signatures #717

merged 1 commit into from
Jan 17, 2023

Conversation

kbattocchi
Copy link
Collaborator

No description provided.

@kbattocchi kbattocchi force-pushed the kebatt/refactorPanelDml branch from 8120102 to db4978f Compare January 17, 2023 15:56
@kbattocchi kbattocchi force-pushed the kebatt/refactorPanelDml branch from db4978f to fa5c9e2 Compare January 17, 2023 16:18
@kbattocchi kbattocchi marked this pull request as ready for review January 17, 2023 16:43
@kbattocchi kbattocchi requested a review from fverac January 17, 2023 16:43
fverac
fverac approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@fverac fverac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@kbattocchi kbattocchi enabled auto-merge (rebase) January 17, 2023 17:51
@kbattocchi kbattocchi merged commit d1baba1 into main Jan 17, 2023
@kbattocchi kbattocchi deleted the kebatt/refactorPanelDml branch January 17, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fverac fverac fverac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbattocchi @fverac